netdev - Re: [PATCH bpf-next 1/2] libbpf: usdt: factor out common USDT arg handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Apr 2022 20:26:36 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alan Maguire <alan.maguire@...cle.com>
Cc:     Andrii Nakryiko <andrii@...nel.org>,
        Ilya Leoshkevich <iii@...ux.ibm.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin Lau <kafai@...com>, Song Liu <songliubraving@...com>,
        Yonghong Song <yhs@...com>,
        john fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next 1/2] libbpf: usdt: factor out common USDT arg handling

On Fri, Apr 8, 2022 at 3:53 PM Alan Maguire <alan.maguire@...cle.com> wrote:
>
> Common code to initialize a struct usdt_arg_spec can be factored out
> from arch-specific flavours of parse_usdt_arg(); signed size,
> bitshift handling etc.
>
> Signed-off-by: Alan Maguire <alan.maguire@...cle.com>
> ---

I understand that there is a bit of repetition between multiple
architectures, but I think this init_usdt_arg_spec() helper is
actually hindering understand. Can you please drop this refactoring
for now? It's just a few lines of code that you'll need to copy/paste
for argument bit shift handling, not a big deal, right?

>  tools/lib/bpf/usdt.c | 90 ++++++++++++++++++++++++----------------------------
>  1 file changed, 41 insertions(+), 49 deletions(-)
>

[...]