lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 14 Apr 2022 11:59:01 -0400
From:   Jamal Hadi Salim <>
To:     Eric Dumazet <>,
        "David S . Miller" <>,
        Jakub Kicinski <>,
        Paolo Abeni <>
Cc:     Cong Wang <>,
        Jiri Pirko <>, netdev <>,
        Eric Dumazet <>,
        syzbot <>
Subject: Re: [PATCH net 1/2] net/sched: cls_u32: fix netns refcount changes in

On 2022-04-13 13:35, Eric Dumazet wrote:
> From: Eric Dumazet <>
> We are now able to detect extra put_net() at the moment
> they happen, instead of much later in correct code paths.
> u32_init_knode() / tcf_exts_init() populates the ->
> pointer, but as mentioned in tcf_exts_init(),
> the refcount on netns has not been elevated yet.
> The refcount is taken only once tcf_exts_get_net()
> is called.
> So the two u32_destroy_key() calls from u32_change()
> are attempting to release an invalid reference on the netns.

Looks good to me.

Acked-by: Jamal Hadi Salim <>


Powered by blists - more mailing lists