netdev - Re: [PATCH net 2/2] net/sched: cls_u32: fix possible leak in u32_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05a27957-ffab-093e-1448-3d32ce2e8cfb@mojatatu.com>
Date:   Thu, 14 Apr 2022 12:03:26 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>, netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net 2/2] net/sched: cls_u32: fix possible leak in
 u32_init_knode()

On 2022-04-13 13:35, Eric Dumazet wrote:
> From: Eric Dumazet<edumazet@...gle.com>
> 
> While investigating a related syzbot report,
> I found that whenever call to tcf_exts_init()
> from u32_init_knode() is failing, we end up
> with an elevated refcount on ht->refcnt
> 
> To avoid that, only increase the refcount after
> all possible errors have been evaluated.
> 
> Fixes: b9a24bb76bf6 ("net_sched: properly handle failure case of tcf_exts_init()")
> Signed-off-by: Eric Dumazet<edumazet@...gle.com>
> Cc: Jamal Hadi Salim<jhs@...atatu.com>
> Cc: Cong Wang<xiyou.wangcong@...il.com>
> Cc: Jiri Pirko<jiri@...nulli.us>


Acked-by: Jamal Hadi Salim <jhs@...atatu.com>


cheers,
jamal