lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Apr 2022 16:35:28 +0200 From: Andrew Lunn <andrew@...n.ch> To: Luiz Angelo Daros de Luca <luizluca@...il.com> Cc: Alvin Šipraga <ALSI@...g-olufsen.dk>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "tobias@...dekranz.com" <tobias@...dekranz.com>, "f.fainelli@...il.com" <f.fainelli@...il.com>, "vladimir.oltean@....com" <vladimir.oltean@....com>, "corbet@....net" <corbet@....net>, "kuba@...nel.org" <kuba@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>, Arınç ÜNAL <arinc.unal@...nc9.com> Subject: Re: [PATCH net-next] net: dsa: realtek: add compatible strings for RTL8367RB-VB > Now, about dt-bindings, I don't know what is the best approach. As > device-tree should not focus on Linux, it is strange to use a > compatible "rtl8365mb" just because it is the Linux subdriver name and > that name was just because it was the first device supported. What you are trying to express is, how do you access the ID register. There is no obvious One True Compatible string for that. So just picking one switch name for that is O.K. There is nothing Linux specific in that, FreeBSD or whatever can use the label as a clue where to find the ID register. > + realtek,rtl8365mb: > + Use with models RTL8363NB, RTL8363NB-VB, RTL8363SC, RTL8363SC-VB, > + RTL8364NB, RTL8364NB-VB, RTL8365MB, RTL8366SC, RTL8367RB-VB, RTL8367S, > + RTL8367SB, RTL8370MB, RTL8310SR > + realtek,rtl8367rb: > + Use with models RTL8366RB, RTL8366S So to me, this is fine. But i might add a bit more detail, that the compatible is used by the driver to find the ID register, and the driver then uses to ID register to decide how to drive the switch. The problem i had with the mv88e6xxx binding was until i spelt this out in the binding, people kept submitting patches adding new compatible strings, rather than extend the documented list of switches supported by a compatible. Andrew
Powered by blists - more mailing lists