lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 16 Apr 2022 12:40:00 -0700
From:   Florian Fainelli <>
To:     Jakob Koschel <>,
        "David S. Miller" <>
Cc:     Jakub Kicinski <>, Paolo Abeni <>,
        Andrew Lunn <>,
        Vivien Didelot <>,
        Vladimir Oltean <>,
        Lars Povlsen <>,
        Steen Hegelund <>,, Ariel Elior <>,
        Manish Chopra <>,
        Edward Cree <>,
        Martin Habets <>,
        Michael Ellerman <>,
        Benjamin Herrenschmidt <>,
        Paul Mackerras <>,
        Jiri Pirko <>,
        Alexei Starovoitov <>,
        Daniel Borkmann <>,
        Andrii Nakryiko <>,
        Martin KaFai Lau <>,
        Song Liu <>, Yonghong Song <>,
        John Fastabend <>,
        KP Singh <>,
        Casper Andersson <>,
        Bjarni Jonasson <>,
        Christophe JAILLET <>,
        Arnd Bergmann <>,
        Colin Ian King <>,
        Eric Dumazet <>,
        Xu Wang <>,,,,,,
        Mike Rapoport <>,
        Brian Johannesmeyer <>,
        Cristiano Giuffrida <>,
        "Bos, H.J." <>,
        Vladimir Oltean <>
Subject: Re: [PATCH net-next v4 02/18] net: dsa: sja1105: remove use of
 iterator after list_for_each_entry() loop

On 4/15/2022 5:29 AM, Jakob Koschel wrote:
> From: Vladimir Oltean <>
> The link below explains that there is a desire to syntactically change
> list_for_each_entry() and list_for_each() such that it becomes
> impossible to use the iterator variable outside the scope of the loop.
> Although sja1105_insert_gate_entry() makes legitimate use of the
> iterator pointer when it breaks out, the pattern it uses may become
> illegal, so it needs to change.
> It is deemed acceptable to use a copy of the loop iterator, and
> sja1105_insert_gate_entry() only needs to know the list_head element
> before which the list insertion should be made. So let's profit from the
> occasion and refactor the list iteration to a dedicated function.
> An additional benefit is given by the fact that with the helper function
> in place, we no longer need to special-case the empty list, since it is
> equivalent to not having found any gating entry larger than the
> specified interval in the list. We just need to insert at the tail of
> that list (list_add vs list_add_tail on an empty list does the same
> thing).
> Link:
> Signed-off-by: Vladimir Oltean <>
> Signed-off-by: Jakob Koschel <>

Reviewed-by: Florian Fainelli <>

Powered by blists - more mailing lists