lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 16 Apr 2022 12:40:38 -0700
From:   Florian Fainelli <>
To:     Kurt Kanzenbach <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Paolo Abeni <>
Cc:     Andrew Lunn <>,
        Vivien Didelot <>,
        Vladimir Oltean <>,
Subject: Re: [PATCH net] net: dsa: hellcreek: Calculate checksums in tagger

On 4/15/2022 3:33 AM, Kurt Kanzenbach wrote:
> In case the checksum calculation is offloaded to the DSA master network
> interface, it will include the switch trailing tag. As soon as the switch strips
> that tag on egress, the calculated checksum is wrong.
> Therefore, add the checksum calculation to the tagger (if required) before
> adding the switch tag. This way, the hellcreek code works with all DSA master
> interfaces regardless of their declared feature set.
> Fixes: 01ef09caad66 ("net: dsa: Add tag handling for Hirschmann Hellcreek switches")
> Signed-off-by: Kurt Kanzenbach <>

Reviewed-by: Florian Fainelli <>

Powered by blists - more mailing lists