netdev - Re: [PATCH net-next] tcp: fix signed/unsigned comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iL5+4YkUSMLUZxy2ed9gDjpQxJzJUoSbgyeH7iNuc9ExQ@mail.gmail.com>
Date:   Sun, 17 Apr 2022 11:28:59 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Andreas Schwab <schwab@...ux-m68k.org>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        netdev <netdev@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next] tcp: fix signed/unsigned comparison

On Sun, Apr 17, 2022 at 11:24 AM Andreas Schwab <schwab@...ux-m68k.org> wrote:
>
> On Apr 17 2022, Eric Dumazet wrote:
>
> > diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> > index cf2dc19bb8c766c1d33406053fd61c0873f15489..0d88984e071531fb727bdee178b0c01fd087fe5f 100644
> > --- a/net/ipv4/tcp_input.c
> > +++ b/net/ipv4/tcp_input.c
> > @@ -5959,7 +5959,7 @@ void tcp_rcv_established(struct sock *sk, struct sk_buff *skb)
> >
> >  step5:
> >       reason = tcp_ack(sk, skb, FLAG_SLOWPATH | FLAG_UPDATE_TS_RECENT);
> > -     if (reason < 0)
> > +     if ((int)reason < 0)
> >               goto discard;
> >
> >       tcp_rcv_rtt_measure_ts(sk, skb);
>
> Shouldn't reason be negated before passing it to tcp_drop_reason?

Good catch, thanks !