netdev - Re: [PATCH net 0/2] net: fix kernel dropping GSO tagged packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ylz7s/I8EUca82NL@Laptop-X1>
Date:   Mon, 18 Apr 2022 13:48:35 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     netdev@...r.kernel.org
Cc:     "Michael S . Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxim Mikityanskiy <maximmi@...lanox.com>,
        Willem de Bruijn <willemb@...gle.com>,
        virtualization@...ts.linux-foundation.org,
        Balazs Nemeth <bnemeth@...hat.com>,
        Mike Pattrick <mpattric@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net 0/2] net: fix kernel dropping GSO tagged packets

Sorry, cc Mick for the correct address

On Mon, Apr 18, 2022 at 12:43:37PM +0800, Hangbin Liu wrote:
> Flavio reported that the kernel drops GSO VLAN tagged packet if it's
> created with socket(AF_PACKET, SOCK_RAW, 0) plus virtio_net_hdr.
> 
> The reason is AF_PACKET doesn't adjust the skb network header if there is
> a VLAN tag. And in virtio_net_hdr_to_skb() it also checks skb->protocol
> blindly and not take care of VLAN tags.
> 
> The first patch adjust the network header position for AF_PACKET VLAN
> tagged packets. The second patch fixes the VLAN protocol checking in
> virtio_net_hdr_to_skb().
> 
> Hangbin Liu (2):
>   net/af_packet: adjust network header position for VLAN tagged packets
>   virtio_net: check L3 protocol for VLAN packets
> 
>  include/linux/virtio_net.h | 26 +++++++++++++++++++-------
>  net/packet/af_packet.c     | 18 +++++++++++++-----
>  2 files changed, 32 insertions(+), 12 deletions(-)
> 
> -- 
> 2.35.1
>