lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20220418061430.6605-1-eng.alaamohamedsoliman.am@gmail.com> Date: Mon, 18 Apr 2022 08:14:30 +0200 From: Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com> To: outreachy@...ts.linux.dev Cc: jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, ira.weiny@...el.com, eng.alaamohamedsoliman.am@...il.com Subject: [PATCH v4] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page() The use of kmap() is being deprecated in favor of kmap_local_page() where it is feasible. With kmap_local_page(), the mapping is per thread, CPU local and not globally visible. Therefore igb_check_lbtest_frame() is a function where the use of kmap_local_page() in place of kmap() is correctly suited. Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com> --- changes in V2: fix kunmap_local path value to take address of the mapped page. --- changes in V3: edit commit message to be clearer --- changes in V4: edit the commit message --- drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c index 2a5782063f4c..c14fc871dd41 100644 --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c @@ -1798,14 +1798,14 @@ static int igb_check_lbtest_frame(struct igb_rx_buffer *rx_buffer, frame_size >>= 1; - data = kmap(rx_buffer->page); + data = kmap_local_page(rx_buffer->page); if (data[3] != 0xFF || data[frame_size + 10] != 0xBE || data[frame_size + 12] != 0xAF) match = false; - kunmap(rx_buffer->page); + kunmap_local(data); return match; } -- 2.35.2
Powered by blists - more mailing lists