netdev - Re: [PATCH v5 net-next 1/4] rtnetlink: return ENODEV when ifname does not exist and group is given

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d63921e9-2306-a153-48fe-a1f65157aafa@wifirst.fr>
Date:   Tue, 19 Apr 2022 09:29:37 +0200
From:   Florent Fourcot <florent.fourcot@...irst.fr>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, cong.wang@...edance.com,
        edumazet@...gle.com, Brian Baboch <brian.baboch@...irst.fr>
Subject: Re: [PATCH v5 net-next 1/4] rtnetlink: return ENODEV when ifname does
 not exist and group is given

Hello,


>> +		if (link_specified)
>> +			return -ENODEV;
> 
> Please add extack error message as well?
> Simple errno's are harder to debug.


What kind of message have you in mind for that one? Something like 
"Interface not found" does not have extra information for ENODEV code.

At this place, one gave interface index or interface name, and nothing 
matched.


Thanks,

-- 
Florent Fourcot.