lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <5f5be1321b5ba6b721f9d0aab563d36133328d33.camel@redhat.com> Date: Tue, 19 Apr 2022 09:29:29 +0200 From: Paolo Abeni <pabeni@...hat.com> To: Christophe Leroy <christophe.leroy@...roup.eu>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org> Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH net-next v2] sungem: Prepare cleanup of powerpc's asm/prom.h Hello, On Fri, 2022-04-15 at 10:43 +0200, Christophe Leroy wrote: > powerpc's asm/prom.h brings some headers that it doesn't > need itself. > > In order to clean it up in a further step, first clean all > files that include asm/prom.h > > Some files don't need asm/prom.h at all. For those ones, > just remove inclusion of asm/prom.h > > Some files don't need any of the items provided by asm/prom.h, > but need some of the headers included by asm/prom.h. For those > ones, add the needed headers that are brought by asm/prom.h at > the moment, then remove asm/prom.h > > Some files really need asm/prom.h but also need some of the > headers included by asm/prom.h. For those one, leave asm/prom.h > but also add the needed headers so that they can be removed > from asm/prom.h in a later step. This commit message is a little confusing, as this patch covers only a single case of the above. I suggest to replace re-phrase the commit message to be more specific. You could also explcitly mention which symbols from linux/of.h sungem_phy.c needs, if the list is short. Thanks, Paolo
Powered by blists - more mailing lists