netdev - Re: [PATCH net-next] PCI: add Corigine vendor ID into pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Apr 2022 15:42:11 +0800
From:   Yinjun Zhang <yinjun.zhang@...igine.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-pci@...r.kernel.org, Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH net-next] PCI: add Corigine vendor ID into pci_ids.h

On Wed, Apr 20, 2022 at 09:12:34AM +0300, Leon Romanovsky wrote:
> On Wed, Apr 20, 2022 at 09:59:52AM +0800, Yinjun Zhang wrote:
> > On Wed, Apr 20, 2022 at 12:00:05AM +0200, Andrew Lunn wrote:
> > > On Tue, Apr 19, 2022 at 06:02:48PM +0800, Yinjun Zhang wrote:
> > > > Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> > > > Cc: linux-pci@...r.kernel.org
> > > > Signed-off-by: Yinjun Zhang <yinjun.zhang@...igine.com>
> > > > Signed-off-by: Simon Horman <simon.horman@...igine.com>
> > > > ---
> > > >  include/linux/pci_ids.h | 2 ++
> > > 
> > > The very top of this file says:
> > > 
> > >  *      Do not add new entries to this file unless the definitions
> > >  *      are shared between multiple drivers.
> > > 
> > > Please add to the commit messages the two or more drivers which share
> > > this definition.
> > 
> > It will be used by ethernet and infiniband driver as we can see now,
> > I'll update the commit message if you think it's a good practice.
> 
> Are you going to submit completely separated infiniband driver that has
> PCI logic in drivers/infiniband without connection todrivers/net/ethernet ...?
> 
> If yes, it is very uncommon in infiniband world.

No, we'll follow the convention, the connection with driver/net/ethernet
is necessary. We've discussed internally that direct ref to VID/DID is not
a good way.

I'll move the VID macro into driver header files for now.
Also thanks for pointing this out, Andrew. 

Cc: Bjorn Helgaas

> 
> I would like to see this PCI patch submitted when it is actually used.
> 
> Thanks
> 
> > 
> > > 
> > > Thanks
> > > 
> > >      Andrew