netdev - Re: [PATCH 2/2] net: macb: In ZynqMP initialization make SGMII phy configuration optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df99f712-f02b-c331-601b-5e61e4766ccc@xilinx.com>
Date:   Wed, 20 Apr 2022 13:17:14 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>,
        <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <robh+dt@...nel.org>, <krzk+dt@...nel.org>,
        <nicolas.ferre@...rochip.com>, <claudiu.beznea@...rochip.com>
CC:     <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <harinik@...inx.com>,
        <git@...inx.com>
Subject: Re: [PATCH 2/2] net: macb: In ZynqMP initialization make SGMII phy
 configuration optional



On 4/20/22 13:03, Radhey Shyam Pandey wrote:
> In the macb binding documentation "phys" is an optional property. Make
> implementation in line with it. This change allows the traditional flow
> in which first stage bootloader does PS-GT configuration to work along
> with newer use cases in which PS-GT configuration is managed by the
> phy-zynqmp driver.
> 
> It fixes below macb probe failure when macb DT node doesn't have SGMII
> phys handle.
> "macb ff0b0000.ethernet: error -ENODEV: failed to get PS-GTR PHY"
> 
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
> ---
>   drivers/net/ethernet/cadence/macb_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index a5140d4d3baf..6434e74c04f1 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4588,7 +4588,7 @@ static int zynqmp_init(struct platform_device *pdev)
>   
>   	if (bp->phy_interface == PHY_INTERFACE_MODE_SGMII) {
>   		/* Ensure PS-GTR PHY device used in SGMII mode is ready */
> -		bp->sgmii_phy = devm_phy_get(&pdev->dev, "sgmii-phy");
> +		bp->sgmii_phy = devm_phy_optional_get(&pdev->dev, NULL);
>   
>   		if (IS_ERR(bp->sgmii_phy)) {
>   			ret = PTR_ERR(bp->sgmii_phy);

Reviewed-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal