netdev - Re: [PATCH net-next] Revert "rtnetlink: return EINVAL when request cannot succeed"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Apr 2022 18:15:56 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Florent Fourcot <florent.fourcot@...irst.fr>,
        netdev@...r.kernel.org
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Brian Baboch <brian.baboch@...irst.fr>
Subject: Re: [PATCH net-next] Revert "rtnetlink: return EINVAL when request
 cannot succeed"


On 4/19/22 05:51, Florent Fourcot wrote:
> This reverts commit b6177d3240a4
>
> ip-link command is testing kernel capability by sending a RTM_NEWLINK
> request, without any argument. It accepts everything in reply, except
> EOPNOTSUPP and EINVAL (functions iplink_have_newlink / accept_msg)
>
> So we must keep compatiblity here, invalid empty message should not
> return EINVAL
>
> Signed-off-by: Florent Fourcot <florent.fourcot@...irst.fr>


Reviewed-by: Eric Dumazet <edumazet@...gle.com>


Thanks for fixing this issue.