lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 20 Apr 2022 19:00:01 -0700
From:   Eric Dumazet <>
To:     Francesco Ruggeri <>
Cc:     Paolo Abeni <>, Jakub Kicinski <>,
        David Ahern <>,
        Hideaki YOSHIFUJI <>,
        David Miller <>,
        LKML <>,
        netdev <>
Subject: Re: [PATCH v2 net] tcp: md5: incorrect tcp_header_len for incoming connections

On Wed, Apr 20, 2022 at 5:50 PM Francesco Ruggeri <> wrote:
> In tcp_create_openreq_child we adjust tcp_header_len for md5 using the
> remote address in newsk. But that address is still 0 in newsk at this
> point, and it is only set later by the callers (tcp_v[46]_syn_recv_sock).
> Use the address from the request socket instead.
> Fixes: cfb6eeb4c860 ("[TCP]: MD5 Signature Option (RFC2385) support.")
> Signed-off-by: Francesco Ruggeri <>

Thanks for fixing this Francesco.

Reviewed-by: Eric Dumazet <>

Powered by blists - more mailing lists