lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Apr 2022 08:08:48 +0200 From: Ivan Vecera <ivecera@...hat.com> To: Leon Romanovsky <leon@...nel.org> Cc: netdev@...r.kernel.org, poros@...hat.com, mschmidt@...hat.com, Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Dave Ertman <david.m.ertman@...el.com>, Shiraz Saleem <shiraz.saleem@...el.com>, "moderated list:INTEL ETHERNET DRIVERS" <intel-wired-lan@...ts.osuosl.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net v2] ice: Fix race during aux device (un)plugging On Thu, 21 Apr 2022 08:12:58 +0300 Leon Romanovsky <leon@...nel.org> wrote: > > static struct iidc_auxiliary_drv *ice_get_auxiliary_drv(struct ice_pf *pf) > > { > > struct auxiliary_device *adev; > > > > + BUG_ON(!mutex_is_locked(&pf->adev_mutex)); > > Please don't add BUG_ON() in driver code. > > I think that you are looking for lockdep_assert_held(&pf->adev_mutex). Will fix. I.
Powered by blists - more mailing lists