lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Apr 2022 14:45:12 +0800 From: kernel test robot <lkp@...el.com> To: Josua Mayer <josua@...id-run.com>, netdev@...r.kernel.org Cc: kbuild-all@...ts.01.org, alvaro.karsz@...id-run.com, Josua Mayer <josua@...id-run.com>, Michael Hennerich <michael.hennerich@...log.com>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com> Subject: Re: [PATCH v2 2/3] net: phy: adin: add support for clock output Hi Josua, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net/master net-next/master v5.18-rc3 next-20220420] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Josua-Mayer/dt-bindings-net-adin-document-phy-clock-output-properties/20220419-192719 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: openrisc-randconfig-s032-20220420 (https://download.01.org/0day-ci/archive/20220421/202204211324.qgcPMycQ-lkp@intel.com/config) compiler: or1k-linux-gcc (GCC) 11.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/intel-lab-lkp/linux/commit/74d856f1c89a6534fd58889f20ad4b481b8191c9 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Josua-Mayer/dt-bindings-net-adin-document-phy-clock-output-properties/20220419-192719 git checkout 74d856f1c89a6534fd58889f20ad4b481b8191c9 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/net/phy/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@...el.com> sparse warnings: (new ones prefixed by >>) >> drivers/net/phy/adin.c:448:27: sparse: sparse: Using plain integer as NULL pointer vim +448 drivers/net/phy/adin.c 444 445 static int adin_config_clk_out(struct phy_device *phydev) 446 { 447 struct device *dev = &phydev->mdio.dev; > 448 const char *val = 0; 449 u8 sel = 0; 450 451 device_property_read_string(dev, "adi,phy-output-clock", &val); 452 if(!val) { 453 /* property not present, do not enable GP_CLK pin */ 454 } else if(strcmp(val, "25mhz-reference") == 0) { 455 sel |= ADIN1300_GE_CLK_CFG_25; 456 } else if(strcmp(val, "125mhz-free-running") == 0) { 457 sel |= ADIN1300_GE_CLK_CFG_FREE_125; 458 } else if(strcmp(val, "125mhz-recovered") == 0) { 459 sel |= ADIN1300_GE_CLK_CFG_RCVR_125; 460 } else if(strcmp(val, "adaptive-free-running") == 0) { 461 sel |= ADIN1300_GE_CLK_CFG_HRT_FREE; 462 } else if(strcmp(val, "adaptive-recovered") == 0) { 463 sel |= ADIN1300_GE_CLK_CFG_HRT_RCVR; 464 } else { 465 phydev_err(phydev, "invalid adi,phy-output-clock\n"); 466 return -EINVAL; 467 } 468 469 if(device_property_read_bool(dev, "adi,phy-output-reference-clock")) 470 sel |= ADIN1300_GE_CLK_CFG_REF_EN; 471 472 return phy_modify_mmd(phydev, MDIO_MMD_VEND1, ADIN1300_GE_CLK_CFG_REG, 473 ADIN1300_GE_CLK_CFG_MASK, sel); 474 } 475 -- 0-DAY CI Kernel Test Service https://01.org/lkp
Powered by blists - more mailing lists