lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 25 Apr 2022 10:55:52 -0700
From:   Francesco Ruggeri <>
To:     Eric Dumazet <>
Cc:     Paolo Abeni <>, Jakub Kicinski <>,
        David Ahern <>,
        Hideaki YOSHIFUJI <>,
        David Miller <>,
        LKML <>,
        netdev <>
Subject: Re: [PATCH v2 net] tcp: md5: incorrect tcp_header_len for incoming connections

On Sun, Apr 24, 2022 at 12:37 PM Eric Dumazet <> wrote:
> Wait a minute.
> Are you sure treq->af_specific is initialized at this point ?
> I should have tested this one liner patch really :/
> I think that for syncookies, treq->af_specific is not initialized,
> because we do not go through
> tcp_conn_request() helper, but instead use cookie_tcp_reqsk_alloc()
> Before your patch treq->af_specific was only used during SYNACK
> generation, which does not happen in syncookie more while receiving
> the third packet.
> I will test something like this patch. We could move the init after
> cookie_tcp_reqsk_alloc() has been called, but I prefer using the same
> construct than tcp_conn_request()

Thanks for fixing this Eric. I had not considered syncookies.


Powered by blists - more mailing lists