lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 25 Apr 2022 11:02:59 -0700
From:   Jakub Kicinski <>
To:     Peilin Ye <>
Cc:     "David S. Miller" <>,
        Hideaki YOSHIFUJI <>,
        David Ahern <>,
        Paolo Abeni <>,
        Peilin Ye <>,
        Cong Wang <>,
        Eric Dumazet <>,,
Subject: Re: [PATCH net-next 0/2] Make [IP6]GRE[TAP] devices always

On Thu, 21 Apr 2022 15:43:42 -0700 Peilin Ye wrote:
> This patchset depends on these fixes [1].  Since o_seqno is now atomic_t,
> we can always turn on NETIF_F_LLTX for [IP6]GRE[TAP] devices, since we no
> longer need the TX lock (&txq->_xmit_lock).

LGTM, thanks, but please repost on Thu / Fri. The fixes make their way
into net-next on Thu so until then we can't apply.

> We could probably do the same thing to [IP6]ERSPAN devices as well, but
> I'm not familiar with them yet.  For example, ERSPAN devices are
> initialized as |= GRE_FEATURES in erspan_tunnel_init(), but I don't see
> IP6ERSPAN devices being initialized as |= GRE6_FEATURES.  Please suggest
> if I'm missing something, thanks!

Probably good to CC William when you repost.

Powered by blists - more mailing lists