netdev - Re: [PATCH net-next 03/14] eth: cpsw: remove a copy of the NAPI_POLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220427154702.fbpxfjp4h7ey5ea2@skbuf>
Date:   Wed, 27 Apr 2022 15:47:03 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "grygorii.strashko@...com" <grygorii.strashko@...com>,
        "chi.minghao@....com.cn" <chi.minghao@....com.cn>,
        "toke@...hat.com" <toke@...hat.com>,
        "chenhao288@...ilicon.com" <chenhao288@...ilicon.com>,
        "moyufeng@...wei.com" <moyufeng@...wei.com>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCH net-next 03/14] eth: cpsw: remove a copy of the
 NAPI_POLL_WEIGHT define

On Wed, Apr 27, 2022 at 08:41:00AM -0700, Jakub Kicinski wrote:
> Defining local versions of NAPI_POLL_WEIGHT with the same
> values in the drivers just makes refactoring harder.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: grygorii.strashko@...com
> CC: chi.minghao@....com.cn
> CC: vladimir.oltean@....com

Fine with me (I mean, I don't even know why I'm copied on cpsw changes).

Why is the weight even an argument to netif_napi_add() anyway?

> CC: toke@...hat.com
> CC: chenhao288@...ilicon.com
> CC: moyufeng@...wei.com
> CC: linux-omap@...r.kernel.org
> ---