netdev - Re: [net: PATCH] net: dsa: add missing refcount decrementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Apr 2022 20:25:14 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Marcin Wojtas <mw@...ihalf.com>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        davem@...emloft.net, kuba@...nel.org, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        upstream@...ihalf.com
Subject: Re: [net: PATCH] net: dsa: add missing refcount decrementation

On Mon, Apr 25, 2022 at 11:47:08AM +0200, Marcin Wojtas wrote:
> After obtaining the "phy-handle" node, decrementing
> refcount is required. Fix that.
> 
> Fixes: a20f997010c4 ("net: dsa: Don't instantiate phylink for CPU/DSA ports unless needed")
> Signed-off-by: Marcin Wojtas <mw@...ihalf.com>
> ---
>  net/dsa/port.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/dsa/port.c b/net/dsa/port.c
> index 32d472a82241..cdc56ba11f52 100644
> --- a/net/dsa/port.c
> +++ b/net/dsa/port.c
> @@ -1620,8 +1620,10 @@ int dsa_port_link_register_of(struct dsa_port *dp)
>  			if (ds->ops->phylink_mac_link_down)
>  				ds->ops->phylink_mac_link_down(ds, port,
>  					MLO_AN_FIXED, PHY_INTERFACE_MODE_NA);
> +			of_node_put(phy_np);
>  			return dsa_port_phylink_register(dp);
>  		}
> +		of_node_put(phy_np);
>  		return 0;
>  	}
>  
> -- 
> 2.29.0
> 

Thanks for the patch.

commit fc06b2867f4cea543505acfb194c2be4ebf0c7d3
Author: Miaoqian Lin <linmq006@...il.com>
Date:   Wed Apr 20 19:04:08 2022 +0800

    net: dsa: Add missing of_node_put() in dsa_port_link_register_of

    The device_node pointer is returned by of_parse_phandle()  with refcount
    incremented. We should use of_node_put() on it when done.
    of_node_put() will check for NULL value.

    Fixes: a20f997010c4 ("net: dsa: Don't instantiate phylink for CPU/DSA ports unless needed")
    Signed-off-by: Miaoqian Lin <linmq006@...il.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>