netdev - Re: [PATCH net] net: enetc: allow tc-etf offload even with NETIF_F_CSUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165116461250.18870.3559010123385422525.git-patchwork-notify@kernel.org>
Date:   Thu, 28 Apr 2022 16:50:12 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
        pabeni@...hat.com, ioana.ciornei@....com, claudiu.manoil@....com
Subject: Re: [PATCH net] net: enetc: allow tc-etf offload even with
 NETIF_F_CSUM_MASK

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 27 Apr 2022 23:30:17 +0300 you wrote:
> The Time-Specified Departure feature is indeed mutually exclusive with
> TX IP checksumming in ENETC, but TX checksumming in itself is broken and
> was removed from this driver in commit 82728b91f124 ("enetc: Remove Tx
> checksumming offload code").
> 
> The blamed commit declared NETIF_F_HW_CSUM in dev->features to comply
> with software TSO's expectations, and still did the checksumming in
> software by calling skb_checksum_help(). So there isn't any restriction
> for the Time-Specified Departure feature.
> 
> [...]

Here is the summary with links:
  - [net] net: enetc: allow tc-etf offload even with NETIF_F_CSUM_MASK
    https://git.kernel.org/netdev/net/c/66a2f5ef68fa

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html