netdev - Re: [PATCH net-next v2] selftests: net: vrf_strict_mode_test: add support to select a test to run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA1TwFD5wfA9oXT1PrbLsootEO_C=PAeytbeQFwj=Go8+gc1CQ@mail.gmail.com>
Date:   Thu, 28 Apr 2022 12:50:02 -0400
From:   Jaehee <jhpark1013@...il.com>
To:     David Ahern <dsahern@...il.com>
Cc:     Roopa Prabhu <roopa@...dia.com>,
        Outreachy Linux Kernel <outreachy@...ts.linux.dev>,
        Julia Denham <jdenham@...hat.com>,
        Roopa Prabhu <roopa.prabhu@...il.com>,
        Stefano Brivio <sbrivio@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] selftests: net: vrf_strict_mode_test: add
 support to select a test to run

On Sun, Apr 24, 2022 at 12:29 PM David Ahern <dsahern@...il.com> wrote:
>
> On 4/23/22 9:48 PM, Roopa Prabhu wrote:
> >
> > On 4/21/22 09:40, Jaehee Park wrote:
> >> Add a boilerplate test loop to run all tests in
> >> vrf_strict_mode_test.sh. Add a -t flag that allows a selected test to
> >> run.
> >>
> >> Signed-off-by: Jaehee Park <jhpark1013@...il.com>
> >> ---
> >
> > Thanks Jaehee.
> >
> > CC, David Ahern
> >
> > David, this might be an overkill for this test. But nonetheless a step
> > towards bringing some uniformity in the tests.
> >
> > next step is to ideally move this to a library to remove repeating this
> > boilerplate loop in every test.
> >
> >
> > .../selftests/net/vrf_strict_mode_test.sh | 31 ++++++++++++++++++-
> >
> >>   1 file changed, 30 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/tools/testing/selftests/net/vrf_strict_mode_test.sh
> >> b/tools/testing/selftests/net/vrf_strict_mode_test.sh
> >> index 865d53c1781c..ca4379265706 100755
> >> --- a/tools/testing/selftests/net/vrf_strict_mode_test.sh
> >> +++ b/tools/testing/selftests/net/vrf_strict_mode_test.sh
> >> @@ -14,6 +14,8 @@ INIT_NETNS_NAME="init"
> >>     PAUSE_ON_FAIL=${PAUSE_ON_FAIL:=no}
> >>   +TESTS="init testns mix"
> >> +
> >>   log_test()
> >>   {
> >>       local rc=$1
> >> @@ -353,6 +355,23 @@ vrf_strict_mode_tests()
> >>       vrf_strict_mode_tests_mix
> >>   }
>
> Add:
>
> ################################################################################
> # usage
>
> >>   +usage()
> >> +{
> >> +    cat <<EOF
> >> +usage: ${0##*/} OPTS
> >> +
> >> +    -t <test> Test(s) to run (default: all)
> >> +          (options: $TESTS)
> >> +EOF
> >> +}
>
> Add:
>
> ################################################################################
> # main
>
> >> +while getopts ":t:h" opt; do
> >> +    case $opt in
> >> +        t) TESTS=$OPTARG;;
> >> +        h) usage; exit 0;;
> >> +        *) usage; exit 1;;
> >> +    esac
> >> +done
> >> +
> >>   vrf_strict_mode_check_support()
> >>   {
> >>       local nsname=$1
> >> @@ -391,7 +410,17 @@ fi
> >>   cleanup &> /dev/null
> >>     setup
> >> -vrf_strict_mode_tests
> >> +for t in $TESTS
> >> +do
> >> +    case $t in
> >> +    vrf_strict_mode_tests_init|init) vrf_strict_mode_tests_init;;
> >> +    vrf_strict_mode_tests_testns|testns) vrf_strict_mode_tests_testns;;
> >> +    vrf_strict_mode_tests_mix|mix) vrf_strict_mode_tests_mix;;
> >> +
> >> +    help) echo "Test names: $TESTS"; exit 0;;
> >> +
> >> +    esac
> >> +done
> >>   cleanup
> >>     print_log_test_results
>
> This change makes vrf_strict_mode_tests unused. Move the log_section
> before the tests in that function to the function handling the test.
> e.g., move 'log_section "VRF strict_mode test on init network
> namespace"' to vrf_strict_mode_tests_init.
>
> Alsom, make sure you are using tabs for indentation vs spaces.

Hi David,

Sorry about the delay in getting these fixes to you and thank you for
your review and comments! I've sent the revised patch just now.

Thanks,
Jaehee