netdev - Re: [PATCH] Fix le16_to_cpu warning for beacon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGRGNgXJfHc4UOvz5QGDPpUsCLau+0caAsCzFDBnc3EHHgf1xw@mail.gmail.com>
Date:   Fri, 29 Apr 2022 21:16:45 +1000
From:   Julian Calaby <julian.calaby@...il.com>
To:     Srinivasan Raju <srini.raju@...elifi.com>
Cc:     Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "open list:NETWORKING DRIVERS (WIRELESS)" 
        <linux-wireless@...r.kernel.org>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix le16_to_cpu warning for beacon_interval

Hi Srinivasan,

On Fri, Apr 29, 2022 at 8:49 PM Srinivasan Raju <srini.raju@...elifi.com> wrote:
>
> Fixed the following warning
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype]
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Srinivasan Raju <srini.raju@...elifi.com>
> ---
>  drivers/net/wireless/purelifi/plfxlc/chip.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/purelifi/plfxlc/chip.c b/drivers/net/wireless/purelifi/plfxlc/chip.c
> index a5ec10b66ed5..5d952ca07195 100644
> --- a/drivers/net/wireless/purelifi/plfxlc/chip.c
> +++ b/drivers/net/wireless/purelifi/plfxlc/chip.c
> @@ -30,10 +30,10 @@ int plfxlc_set_beacon_interval(struct plfxlc_chip *chip, u16 interval,
>  {
>         if (!interval ||
>             (chip->beacon_set &&
> -            le16_to_cpu(chip->beacon_interval) == interval))
> +            chip->beacon_interval) == interval)

Shouldn't that first ")" go at the end of the line?

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/