netdev - Re: [PATCH] net: sfp: Add tx-fault quirk for Huawei MA5671A SFP ONT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL3BVdq-OkoJM8LEXvJLW8HS3n8-VH3KrM-A8CbjUm9SC3r3vw@mail.gmail.com>
Date:   Mon, 2 May 2022 23:32:51 +0100
From:   Matthew Hagan <mnhagan88@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Russell King <linux@...linux.org.uk>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: sfp: Add tx-fault quirk for Huawei MA5671A SFP ONT

On Mon, 2 May 2022 at 19:37, Andrew Lunn <andrew@...n.ch> wrote:
>
> > +     if (!memcmp(id.base.vendor_name, "HUAWEI          ", 16) &&
> > +         !memcmp(id.base.vendor_pn, "MA5671A         ", 16))
> > +             sfp->tx_fault_ignore = true;
> > +     else
> > +             sfp->tx_fault_ignore = false;
> > +
> > +     return 0;
> > +
> >       return 0;
>
> Why do we need two return 0; Probably a merged conflict gone wrong.
>
Apologies for the oversight. Will submit a v2 shortly.
>     Andrew

Matthew