lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 May 2022 12:25:29 -0500 From: Alex Elder <elder@...e.org> To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net Cc: netdev@...r.kernel.org, pabeni@...hat.com, edumazet@...gle.com, rafal@...ecki.pl, f.fainelli@...il.com, opendmb@...il.com, dmichail@...gible.com, hauke@...ke-m.de, tariqt@...dia.com, kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com, shshaikh@...vell.com, manishc@...vell.com, jiri@...nulli.us, hayashi.kunihiko@...ionext.com, peppe.cavallaro@...com, alexandre.torgue@...s.st.com, joabreu@...opsys.com, mcoquelin.stm32@...il.com, grygorii.strashko@...com, elder@...nel.org, wintera@...ux.ibm.com, wenjia@...ux.ibm.com, svens@...ux.ibm.com, mathew.j.martineau@...ux.intel.com, matthieu.baerts@...sares.net, s-vadapalli@...com, chi.minghao@....com.cn, linux-rdma@...r.kernel.org, linux-hyperv@...r.kernel.org, mptcp@...ts.linux.dev Subject: Re: [PATCH net-next 1/2] net: switch to netif_napi_add_tx() On 5/4/22 11:37 AM, Jakub Kicinski wrote: > Switch net callers to the new API not requiring > the NAPI_POLL_WEIGHT argument. > > Signed-off-by: Jakub Kicinski <kuba@...nel.org> > --- > CC: rafal@...ecki.pl > CC: f.fainelli@...il.com > CC: opendmb@...il.com > CC: dmichail@...gible.com > CC: hauke@...ke-m.de > CC: tariqt@...dia.com > CC: kys@...rosoft.com > CC: haiyangz@...rosoft.com > CC: sthemmin@...rosoft.com > CC: wei.liu@...nel.org > CC: decui@...rosoft.com > CC: shshaikh@...vell.com > CC: manishc@...vell.com > CC: jiri@...nulli.us > CC: hayashi.kunihiko@...ionext.com > CC: peppe.cavallaro@...com > CC: alexandre.torgue@...s.st.com > CC: joabreu@...opsys.com > CC: mcoquelin.stm32@...il.com > CC: grygorii.strashko@...com > CC: elder@...nel.org > CC: wintera@...ux.ibm.com > CC: wenjia@...ux.ibm.com > CC: svens@...ux.ibm.com > CC: mathew.j.martineau@...ux.intel.com > CC: matthieu.baerts@...sares.net > CC: s-vadapalli@...com > CC: chi.minghao@....com.cn > CC: linux-rdma@...r.kernel.org > CC: linux-hyperv@...r.kernel.org > CC: mptcp@...ts.linux.dev > --- > drivers/net/ethernet/broadcom/bcm4908_enet.c | 2 +- > drivers/net/ethernet/broadcom/bcmsysport.c | 2 +- > drivers/net/ethernet/broadcom/genet/bcmgenet.c | 3 +-- > drivers/net/ethernet/fungible/funeth/funeth_main.c | 3 +-- > drivers/net/ethernet/lantiq_xrx200.c | 4 ++-- > drivers/net/ethernet/mellanox/mlx4/en_cq.c | 3 +-- > drivers/net/ethernet/microsoft/mana/mana_en.c | 2 +- > drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 9 ++++----- > drivers/net/ethernet/rocker/rocker_main.c | 3 +-- > drivers/net/ethernet/socionext/sni_ave.c | 3 +-- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 ++--- > drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 ++-- > drivers/net/ethernet/ti/cpsw.c | 5 ++--- > drivers/net/ethernet/ti/cpsw_new.c | 5 ++--- > drivers/net/ethernet/ti/netcp_core.c | 2 +- > drivers/net/ipa/gsi.c | 4 ++-- For drivers/net/ipa/gsi.c: Reviewed-by: Alex Elder <elder@...aro.org> > drivers/net/tun.c | 3 +-- > drivers/s390/net/qeth_core_main.c | 3 +-- > net/mptcp/protocol.c | 4 ++-- > 19 files changed, 29 insertions(+), 40 deletions(-) > . . . > diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c > index bc981043cc80..db4cb2de218c 100644 > --- a/drivers/net/ipa/gsi.c > +++ b/drivers/net/ipa/gsi.c > @@ -1614,8 +1614,8 @@ static int gsi_channel_setup_one(struct gsi *gsi, u32 channel_id) > gsi_channel_program(channel, true); > > if (channel->toward_ipa) > - netif_tx_napi_add(&gsi->dummy_dev, &channel->napi, > - gsi_channel_poll, NAPI_POLL_WEIGHT); > + netif_napi_add_tx(&gsi->dummy_dev, &channel->napi, > + gsi_channel_poll); > else > netif_napi_add(&gsi->dummy_dev, &channel->napi, > gsi_channel_poll, NAPI_POLL_WEIGHT); . . .
Powered by blists - more mailing lists