netdev - Re: [PATCH net-next 1/2] net: switch to netif_napi_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb4dc61f-59a-794-d915-cfabbe469369@linux.intel.com>
Date:   Wed, 4 May 2022 15:01:01 -0700 (PDT)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Jakub Kicinski <kuba@...nel.org>
cc:     davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com,
        edumazet@...gle.com, rafal@...ecki.pl, f.fainelli@...il.com,
        opendmb@...il.com, dmichail@...gible.com, hauke@...ke-m.de,
        tariqt@...dia.com, kys@...rosoft.com, haiyangz@...rosoft.com,
        sthemmin@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
        shshaikh@...vell.com, manishc@...vell.com, jiri@...nulli.us,
        hayashi.kunihiko@...ionext.com, peppe.cavallaro@...com,
        alexandre.torgue@...s.st.com, joabreu@...opsys.com,
        mcoquelin.stm32@...il.com, grygorii.strashko@...com,
        elder@...nel.org, wintera@...ux.ibm.com, wenjia@...ux.ibm.com,
        svens@...ux.ibm.com, matthieu.baerts@...sares.net,
        s-vadapalli@...com, chi.minghao@....com.cn,
        linux-rdma@...r.kernel.org, linux-hyperv@...r.kernel.org,
        mptcp@...ts.linux.dev
Subject: Re: [PATCH net-next 1/2] net: switch to netif_napi_add_tx()

On Wed, 4 May 2022, Jakub Kicinski wrote:

> Switch net callers to the new API not requiring
> the NAPI_POLL_WEIGHT argument.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---

...

> net/mptcp/protocol.c                               | 4 ++--
> 19 files changed, 29 insertions(+), 40 deletions(-)
>

For the MPTCP content:

Acked-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

> diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
> index 52ed2c0ac901..7a9e2545884f 100644
> --- a/net/mptcp/protocol.c
> +++ b/net/mptcp/protocol.c
> @@ -3786,8 +3786,8 @@ void __init mptcp_proto_init(void)
> 	for_each_possible_cpu(cpu) {
> 		delegated = per_cpu_ptr(&mptcp_delegated_actions, cpu);
> 		INIT_LIST_HEAD(&delegated->head);
> -		netif_tx_napi_add(&mptcp_napi_dev, &delegated->napi, mptcp_napi_poll,
> -				  NAPI_POLL_WEIGHT);
> +		netif_napi_add_tx(&mptcp_napi_dev, &delegated->napi,
> +				  mptcp_napi_poll);
> 		napi_enable(&delegated->napi);
> 	}
>
> -- 
> 2.34.1
>
>

--
Mat Martineau
Intel