netdev - Re: [PATCH net-next 1/4] net: add netif_inherit_tso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YnUGKkx0cCi9c06M@corigine.com>
Date:   Fri, 6 May 2022 20:27:38 +0900
From:   Simon Horman <simon.horman@...igine.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, alexander.duyck@...il.com,
        stephen@...workplumber.org, gustavoars@...nel.org,
        roopa@...dia.com, keescook@...omium.org,
        william.xuanziyang@...wei.com, lucien.xin@...il.com,
        oss-drivers@...igine.com
Subject: Re: [PATCH net-next 1/4] net: add netif_inherit_tso_max()

On Thu, May 05, 2022 at 07:51:31PM -0700, Jakub Kicinski wrote:
> To make later patches smaller create a helper for inheriting
> the TSO limitations of a lower device. The TSO in the name
> is not an accident, subsequent patches will replace GSO
> with TSO in more names.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: simon.horman@...igine.com
> CC: gustavoars@...nel.org
> CC: roopa@...dia.com
> CC: keescook@...omium.org
> CC: william.xuanziyang@...wei.com
> CC: lucien.xin@...il.com
> CC: oss-drivers@...igine.com
> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_repr.c |  3 +--
>  drivers/net/ipvlan/ipvlan_main.c                  |  6 ++----
>  drivers/net/macvlan.c                             |  6 ++----
>  drivers/net/veth.c                                |  3 +--
>  drivers/net/vxlan/vxlan_core.c                    |  3 +--
>  include/linux/netdevice.h                         |  3 +++
>  net/8021q/vlan.c                                  |  3 +--
>  net/8021q/vlan_dev.c                              |  3 +--
>  net/core/dev.c                                    | 12 ++++++++++++
>  9 files changed, 24 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> index ba3fa7eac98d..790e1d5e4b4a 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> @@ -286,8 +286,7 @@ nfp_repr_transfer_features(struct net_device *netdev, struct net_device *lower)
>  	if (repr->dst->u.port_info.lower_dev != lower)
>  		return;
>  
> -	netif_set_gso_max_size(netdev, lower->gso_max_size);
> -	netif_set_gso_max_segs(netdev, lower->gso_max_segs);
> +	netif_inherit_tso_max(netdev, lower);
>  
>  	netdev_update_features(netdev);
>  }

NFP portion:

Reviewed-by: Simon Horman <simon.horman@...igine.com>

...