netdev - Re: [PATCH net-next 0/4] net: disambiguate the TSO and GSO limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 19:58:36 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, Paolo Abeni <pabeni@...hat.com>,
        Alexander Duyck <alexander.duyck@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH net-next 0/4] net: disambiguate the TSO and GSO limits

On Thu, May 5, 2022 at 7:51 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> This series separates the device-reported TSO limitations
> from the user space-controlled GSO limits. It used to be that
> we only had the former (HW limits) but they were named GSO.
> This probably lead to confusion and letting user override them.
>
> The problem came up in the BIG TCP discussion between Eric and
> Alex, and seems like something we should address.
>
> Targeting net-next because (a) nobody is reporting problems;
> and (b) there is a tiny but non-zero chance that some actually
> wants to lift the HW limitations.
>
> Jakub Kicinski (4):
>   net: add netif_inherit_tso_max()
>   net: don't allow user space to lift the device limits
>   net: make drivers set the TSO limit not the GSO limit
>   net: move netif_set_gso_max helpers
>

Very nice, thanks Jakub.

BIT TCP patch series looks much nicer after this series, I will post
v3 when your series is merged.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>