netdev - Re: [RFC, net-next] net: qos: introduce a frer action to implement 802.1CB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df67ceaa-4240-d084-7ba1-d703f0c38f33@ericsson.com>
Date:   Fri, 6 May 2022 11:55:56 +0000
From:   Ferenc Fejes <ferenc.fejes@...csson.com>
To:     Xiaoliang Yang <xiaoliang.yang_1@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Arvid.Brodin@...n.com" <Arvid.Brodin@...n.com>,
        "m-karicheri2@...com" <m-karicheri2@...com>,
        "vinicius.gomes@...el.com" <vinicius.gomes@...el.com>,
        "michael.chan@...adcom.com" <michael.chan@...adcom.com>,
        "vishal@...lsio.com" <vishal@...lsio.com>,
        "saeedm@...lanox.com" <saeedm@...lanox.com>,
        "jiri@...lanox.com" <jiri@...lanox.com>,
        "idosch@...lanox.com" <idosch@...lanox.com>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "ivan.khoronzhuk@...aro.org" <ivan.khoronzhuk@...aro.org>,
        "andre.guedes@...ux.intel.com" <andre.guedes@...ux.intel.com>,
        "allan.nielsen@...rochip.com" <allan.nielsen@...rochip.com>,
        "joergen.andreasen@...rochip.com" <joergen.andreasen@...rochip.com>,
        "vladimir.oltean@....com" <vladimir.oltean@....com>,
        "jhs@...atatu.com" <jhs@...atatu.com>
Subject: Re: [RFC, net-next] net: qos: introduce a frer action to implement
 802.1CB

On 2021. 09. 28. 13:44, Xiaoliang Yang wrote:
> This patch introduce a frer action to implement frame replication and
> elimination for reliability, which is defined in IEEE P802.1CB.

HiXiaoliang!

thanks for your efforts to introduce afreraction to implement frame 
replication and elimination for reliability, which is defined in IEEE 
P802.1CB-2017. I would like to relay a small comment from our team, 
regarding to the FRER, not particularly to the code.

Support of RTAG format is very straightforward.

Since 2017, several maintenance items were opened regarding IEEE 
P802.1CB-2017 to fix some errors in the standard. Discussions results 
will be published soon e.g., in IEEE P802.1CBdb 
(https://1.ieee802.org/tsn/802-1cbdb/).

One of the maintenance items impacts the vector recovery algorithm itself.

Details on the problem and the solution are here:

-https://www.802-1.org/items/370

-https://www.ieee802.org/1/files/public/docs2020/maint-varga-257-FRER-recovery-window-0320-v01.pdf 
<https://www.ieee802.org/1/files/public/docs2020/maint-varga-257-FRER-recovery-window-0320-v01.pdf>

It is a small but important fix. There is an incorrect reference to the 
size of the recovery window, when a received packet is checked to be 
out-of-range or not. Without this fix the vector recovery algorithm do 
not work properly in some scenarios.

Please consider to update your patch to reflect the maintenance efforts 
of IEEE to correct .1CB-2017 related issues.

> There are two modes for frer action: generate and push the tag, recover
> and pop the tag. frer tag has three types: RTAG, HSR, and PRP. This
> patch only supports RTAG now.
>
> User can push the tag on egress port of the talker device, recover and
> pop the tag on ingress port of the listener device. When it's a relay
> system, push the tag on ingress port, or set individual recover on
> ingress port. Set the sequence recover on egress port.
>
> Use action "mirred" to do split function, and use "vlan-modify" to do
> active stream identification function on relay system.
>
All of our research in the topic based on a in-house userspace FRER 
implementation but we are looking forward to test your work in the future.

Thanks,

Ferenc