netdev - Re: [PATCH v2 net-next] selftests: forwarding: add Per-Stream Filtering and Policing test for Ocelot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220506120153.yfnnnwplumcilvoj@skbuf>
Date:   Fri, 6 May 2022 12:01:54 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Ferenc Fejes <ferenc.fejes@...csson.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        Gerhard Engleder <gerhard@...leder-embedded.com>,
        "Y.B. Lu" <yangbo.lu@....com>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        Richard Cochran <richardcochran@...il.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Yannick Vignon <yannick.vignon@....com>,
        Rui Sousa <rui.sousa@....com>, Jiri Pirko <jiri@...dia.com>,
        Ido Schimmel <idosch@...dia.com>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "shuah@...nel.org" <shuah@...nel.org>
Subject: Re: [PATCH v2 net-next] selftests: forwarding: add Per-Stream
 Filtering and Policing test for Ocelot

Hi Ferenc,

On Fri, May 06, 2022 at 07:49:40AM +0000, Ferenc Fejes wrote:
> Hi!
> I know that might be little bit off-topic here, but the current
> implementation of the act_gate does nothing with the IPV value [0] even
> if the user set it to non -1.
> IMO this IPV value should be carried through in the tcf_gate struct [1]
> as something like a "current_ipv" member or so. Then this value can be
> applied in the tcf_gate_act function to the skb->priority.
>
> Background story: I tried to combine gate and taprio (802.1Qci and Qbv)
> to achieve 802.1Qch operation (which is really just a coordinated config
> of those two) but without the IPV (should by set by the ingress port) we
> have no way to carry the gating info to the taprio, and as a result its
> just sending every packet with the default priority, no matter how we
> open/close the gate at the ingress.
>
> [0]
> https://elixir.bootlin.com/linux/v5.18-rc5/source/include/net/tc_act/tc_gate.h#L21
> [1]
> https://elixir.bootlin.com/linux/v5.18-rc5/source/include/net/tc_act/tc_gate.h#L40
> [2]
> https://elixir.bootlin.com/linux/v5.18-rc5/source/net/sched/act_gate.c#L117

This is correct. I have been testing only with the offloaded tc-gate
action so I did not notice that the software does not act upon the ipv.
Your proposal sounds straightforward enough. Care to send a bug fix patch?