netdev - Re: [PATCH net-next 5/6] net: virtio: switch to netif_napi_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 7 May 2022 11:08:01 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem <davem@...emloft.net>, netdev <netdev@...r.kernel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>, mst <mst@...hat.com>,
        virtualization <virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH net-next 5/6] net: virtio: switch to netif_napi_add_weight()

On Sat, May 7, 2022 at 1:08 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> virtio netdev driver uses a custom napi weight, switch to the new
> API for setting custom weight.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Acked-by: Jason Wang <jasowang@...hat.com>

> ---
> CC: mst@...hat.com
> CC: jasowang@...hat.com
> CC: virtualization@...ts.linux-foundation.org
> ---
>  drivers/net/virtio_net.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index ebb98b796352..db05b5e930be 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -3313,8 +3313,8 @@ static int virtnet_alloc_queues(struct virtnet_info *vi)
>         INIT_DELAYED_WORK(&vi->refill, refill_work);
>         for (i = 0; i < vi->max_queue_pairs; i++) {
>                 vi->rq[i].pages = NULL;
> -               netif_napi_add(vi->dev, &vi->rq[i].napi, virtnet_poll,
> -                              napi_weight);
> +               netif_napi_add_weight(vi->dev, &vi->rq[i].napi, virtnet_poll,
> +                                     napi_weight);
>                 netif_napi_add_tx_weight(vi->dev, &vi->sq[i].napi,
>                                          virtnet_poll_tx,
>                                          napi_tx ? napi_weight : 0);
> --
> 2.34.1
>