netdev - Re: [PATCH net-next 2/6] caif_virtio: switch to netif_napi_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 7 May 2022 02:55:48 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com,
        edumazet@...gle.com, wanghai38@...wei.com
Subject: Re: [PATCH net-next 2/6] caif_virtio: switch to
 netif_napi_add_weight()

On Fri, May 06, 2022 at 10:07:47AM -0700, Jakub Kicinski wrote:
> caif_virtio uses a custom napi weight, switch to the new
> API for setting custom weights.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Acked-by: Michael S. Tsirkin <mst@...hat.com>

> ---
> CC: mst@...hat.com
> CC: wanghai38@...wei.com
> ---
>  drivers/net/caif/caif_virtio.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c
> index 444ef6a342f6..5458f57177a0 100644
> --- a/drivers/net/caif/caif_virtio.c
> +++ b/drivers/net/caif/caif_virtio.c
> @@ -714,7 +714,8 @@ static int cfv_probe(struct virtio_device *vdev)
>  	/* Initialize NAPI poll context data */
>  	vringh_kiov_init(&cfv->ctx.riov, NULL, 0);
>  	cfv->ctx.head = USHRT_MAX;
> -	netif_napi_add(netdev, &cfv->napi, cfv_rx_poll, CFV_DEFAULT_QUOTA);
> +	netif_napi_add_weight(netdev, &cfv->napi, cfv_rx_poll,
> +			      CFV_DEFAULT_QUOTA);
>  
>  	tasklet_setup(&cfv->tx_release_tasklet, cfv_tx_release_tasklet);
>  
> -- 
> 2.34.1