netdev - RE: [PATCH v4 net-next 2/2] net: phy: smsc: add LAN8742 phy support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH0PR11MB55611C73D1A6472911151BB98EC69@CH0PR11MB5561.namprd11.prod.outlook.com>
Date:   Mon, 9 May 2022 14:24:44 +0000
From:   <Yuiko.Oshino@...rochip.com>
To:     <andrew@...n.ch>
CC:     <kuba@...nel.org>, <Woojung.Huh@...rochip.com>,
        <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <Ravi.Hegde@...rochip.com>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH v4 net-next 2/2] net: phy: smsc: add LAN8742 phy support.

>-----Original Message-----
>From: Andrew Lunn <andrew@...n.ch>
>Sent: Monday, May 9, 2022 9:51 AM
>To: Yuiko Oshino - C18177 <Yuiko.Oshino@...rochip.com>
>Cc: kuba@...nel.org; Woojung Huh - C21699 <Woojung.Huh@...rochip.com>;
>davem@...emloft.net; netdev@...r.kernel.org; Ravi Hegde - C21689
><Ravi.Hegde@...rochip.com>; UNGLinuxDriver <UNGLinuxDriver@...rochip.com>
>Subject: Re: [PATCH v4 net-next 2/2] net: phy: smsc: add LAN8742 phy support.
>
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is
>safe
>
>> So should I create a new series with the missing comments only rather
>> than doing v5?
>
>Yes please.
>
>    Andrew

May I also fix this missing one tab after the phy_id in smsc.c in the same patch?

+	.phy_id	= 0x0007c130,	/* 0x0007c130 and 0x0007c131 */
+	.phy_id_mask	= 0xfffffff2,
+