netdev - Re: [PATCH v4 net-next 2/2] net: phy: smsc: add LAN8742 phy support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220509093510.33bcfea2@kernel.org>
Date:   Mon, 9 May 2022 09:35:10 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     <Yuiko.Oshino@...rochip.com>
Cc:     <andrew@...n.ch>, <Woojung.Huh@...rochip.com>,
        <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <Ravi.Hegde@...rochip.com>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH v4 net-next 2/2] net: phy: smsc: add LAN8742 phy
 support.

On Mon, 9 May 2022 14:24:44 +0000 Yuiko.Oshino@...rochip.com wrote:
> May I also fix this missing one tab after the phy_id in smsc.c in the same patch?
> 
> +	.phy_id	= 0x0007c130,	/* 0x0007c130 and 0x0007c131 */
> +	.phy_id_mask	= 0xfffffff2,
> +

Seems like an okay change to make in addition in adding the comments.
Both are non-functional changes, anyway.