netdev - Re: [RFC PATCH net-next 6/8] net: dsa: remove port argument from ->change_tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJq09z7AUCA9ya+8JJXGV_2NAFZ4W2jjq_OemkVokhOPBXxM_g@mail.gmail.com>
Date:   Mon, 9 May 2022 02:35:48 -0300
From:   Luiz Angelo Daros de Luca <luizluca@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vladimir Oltean <olteanv@...il.com>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Marek Behún <kabel@...nel.org>,
        Ansuel Smith <ansuelsmth@...il.com>,
        DENG Qingfang <dqfext@...il.com>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        UNGLinuxDriver@...rochip.com,
        Colin Foster <colin.foster@...advantage.com>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [RFC PATCH net-next 6/8] net: dsa: remove port argument from ->change_tag_protocol()

> -static int rtl8365mb_change_tag_protocol(struct dsa_switch *ds, int cpu_index,
> +static int rtl8365mb_change_tag_protocol(struct dsa_switch *ds,
>                                          enum dsa_tag_protocol proto)
>  {
>         struct realtek_priv *priv = ds->priv;

For the rtl8365mb family, tag protocol is not a per-port property.

Acked-by: Luiz Angelo Daros de Luca <luizluca@...il.com>