netdev - Re: [RFC PATCH net-next 6/8] net: dsa: remove port argument from ->change_tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220510220536.nxecr6jqxx6kjsgs@skbuf>
Date:   Tue, 10 May 2022 22:05:38 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Luiz Angelo Daros de Luca <luizluca@...il.com>
CC:     "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vladimir Oltean <olteanv@...il.com>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Marek Behún <kabel@...nel.org>,
        Ansuel Smith <ansuelsmth@...il.com>,
        DENG Qingfang <dqfext@...il.com>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Colin Foster <colin.foster@...advantage.com>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [RFC PATCH net-next 6/8] net: dsa: remove port argument from
 ->change_tag_protocol()

On Mon, May 09, 2022 at 02:35:48AM -0300, Luiz Angelo Daros de Luca wrote:
> > -static int rtl8365mb_change_tag_protocol(struct dsa_switch *ds, int cpu_index,
> > +static int rtl8365mb_change_tag_protocol(struct dsa_switch *ds,
> >                                          enum dsa_tag_protocol proto)
> >  {
> >         struct realtek_priv *priv = ds->priv;
> 
> For the rtl8365mb family, tag protocol is not a per-port property.
> 
> Acked-by: Luiz Angelo Daros de Luca <luizluca@...il.com>

Thanks. I'll be resending the series as v2 if there are no other comments.