netdev - Re: [PATCH bpf-next 0/9] selftests: xsk: add busy-poll testing plus various fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220510170746.ujho4d22xao3ingj@MBP-98dd607d3435.dhcp.thefacebook.com>
Date:   Tue, 10 May 2022 10:07:46 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Magnus Karlsson <magnus.karlsson@...il.com>
Cc:     magnus.karlsson@...el.com, bjorn@...nel.org, ast@...nel.org,
        daniel@...earbox.net, netdev@...r.kernel.org,
        maciej.fijalkowski@...el.com, yhs@...com, andrii@...nel.org,
        kafai@...com, songliubraving@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, jonathan.lemon@...il.com, bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next 0/9] selftests: xsk: add busy-poll testing plus
 various fixes

On Tue, May 10, 2022 at 01:55:55PM +0200, Magnus Karlsson wrote:
> This patch set adds busy-poll testing to the xsk selftests. It runs
> exactly the same tests as with regular softirq processing, but with
> busy-poll enabled. I have also included a number of fixes to the
> selftests that have been bugging me for a while or was discovered
> while implementing the busy-poll support. In summary these are:
> 
> * Fix the error reporting of failed tests. Each failed test used to be
>   reported as both failed and passed, messing up things.
> 
> * Added a summary test printout at the end of the test suite so that
>   users do not have to scroll up and look at the result of both the
>   softirq run and the busy_poll run.
> 
> * Added a timeout to the tests, so that if a test locks up, we report
>   a fail and still get to run all the other tests.
> 
> * Made the stats test just look and feel like all the other
>   tests. Makes the code simpler and the test reporting more
>   consistent. These are the 3 last commits.
> 
> * Replaced zero length packets with packets of 64 byte length. This so
>   that some of the tests will pass after commit 726e2c5929de84 ("veth:
>   Ensure eth header is in skb's linear part").
> 
> * Added clean-up of the veth pair when terminating the test run.
> 
> * Some smaller clean-ups of unused stuff.

Sounds like a good set of improvements and fixes.

Bjorn,
please review.