netdev - Re: [PATCH 0/4] net: dsa: realtek: rtl8365mb: Add SGMII and HSGMII support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 May 2022 17:08:55 +0000
From:   Alvin Šipraga <ALSI@...g-olufsen.dk>
To:     Hauke Mehrtens <hauke@...ke-m.de>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 0/4] net: dsa: realtek: rtl8365mb: Add SGMII and HSGMII
 support

Hi Hauke,

Thanks for your series.

On Mon, May 09, 2022 at 12:48:44AM +0200, Hauke Mehrtens wrote:
> This was tested on a Buffalo WSR-2533DHP2. This is a board using a 
> Mediatek MT7622 SoC and its 2.5G Ethernet MAC connected over a 2.5G 
> HSGMII link to a RTL8367S switch providing 5 1G ports.
> This is the only board I have using this switch.
> 
> With the DSA_TAG_PROTO_RTL8_4 tag format the TCP checksum for all TCP 
> send packets is wrong. It is set to 0x83c6. The mac driver probably 
> should do some TCP checksum offload, but it does not work. 
> 
> When I used the DSA_TAG_PROTO_RTL8_4T tag format the send packets are 
> ok, but it looks like the system does TCP Large receive offload, but 
> does not update the TCP checksum correctly. I see that multiple received 
> TCP packets are combined into one (using tcpdump on switch port on 
> device). The switch tag is also correctly removed. tcpdump complains
> that the checksum is wrong, it was updated somewhere, but it is wrong.
> 
> Does anyone know what could be wrong here and how to fix this?
> 
> This uses the rtl8367s-sgmii.bin firmware file. I extracted it from a 
> GPL driver source code with a GPL notice on top. I do not have the 
> source code of this firmware. You can download it here:
> https://hauke-m.de/files/rtl8367/rtl8367s-sgmii.bin
> Here are some information about the source:
> https://hauke-m.de/files/rtl8367/rtl8367s-sgmii.txt
> 
> This file does not look like intentional GPL. It would be nice if 
> Realtek could send this file or a similar version to the linux-firmware 
> repository under a license which allows redistribution. I do not have 
> any contact at Realtek, if someone has a contact there it would be nice 
> if we can help me on this topic.

Let me follow up on this. It will take some days so please be patient.

However, in the worst case, I think that the license header in that file is
pretty explicit: You did not enter any particular licensing agreement with
Realtek, and therefore the code (including those bytes of SGMII firmware) are
licensed to you under the GPL. IANAL but it seems quite clear, no?

> 
> Hauke Mehrtens (4):
>   net: dsa: realtek: rtl8365mb: Fix interface type mask
>   net: dsa: realtek: rtl8365mb: Get chip option
>   net: dsa: realtek: rtl8365mb: Add setting MTU
>   net: dsa: realtek: rtl8365mb: Add SGMII and HSGMII support
> 
>  drivers/net/dsa/realtek/rtl8365mb.c | 444 ++++++++++++++++++++++++++--
>  1 file changed, 413 insertions(+), 31 deletions(-)
> 
> -- 
> 2.30.2
>