netdev - Re: [PATCH net] Documentation: add description for net.core.gro_normal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvbK_dKQSnmn3z41=88Zoa4xGf55G59Y_ocAtoaJh=Y4JGw+A@mail.gmail.com>
Date:   Tue, 10 May 2022 13:10:04 -0400
From:   Xin Long <lucien.xin@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     network dev <netdev@...r.kernel.org>, davem <davem@...emloft.net>,
        Edward Cree <ecree@...arflare.com>
Subject: Re: [PATCH net] Documentation: add description for net.core.gro_normal_batch

On Mon, May 9, 2022 at 9:07 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri,  6 May 2022 14:20:13 -0400 Xin Long wrote:
> > Describe it in admin-guide/sysctl/net.rst like other Network core options.
> > Users need to know gro_normal_batch for performance tuning.
> >
> > Fixes: 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs")
> > Reported-by: Prijesh <prpatel@...hat.com>
>
> Does Prijesh have a last name? :)
'Prijesh <prpatel@...hat.com>' is what I got from his emails.
But yes, he has. 'Prijesh Patel'.

>
> > Signed-off-by: Xin Long <lucien.xin@...il.com>
> > ---
> >  Documentation/admin-guide/sysctl/net.rst | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/Documentation/admin-guide/sysctl/net.rst b/Documentation/admin-guide/sysctl/net.rst
> > index f86b5e1623c6..d8a8506f31ad 100644
> > --- a/Documentation/admin-guide/sysctl/net.rst
> > +++ b/Documentation/admin-guide/sysctl/net.rst
> > @@ -374,6 +374,16 @@ option is set to SOCK_TXREHASH_DEFAULT (i. e. not overridden by setsockopt).
> >  If set to 1 (default), hash rethink is performed on listening socket.
> >  If set to 0, hash rethink is not performed.
> >
> > +gro_normal_batch
> > +----------------
> > +
> > +Maximum number of GRO_NORMAL skbs to batch up for list-RX. When GRO decides
> > +not to coalesce a packet, instead of passing it to the stack immediately,
> > +place it on a list.
>
> That makes it sounds like only packets which were not coalesced
> go on the list. IIUC everything goes on that list before traveling
> up the stack, no?
I think the difference is these ones held/merged go to gro_list first
and get merged there, then go to the list. I can change it to:

"place it on a list where the coalesced packets also eventually go"

looks good?

>
> > +Pass this list to the stack at flush time or whenever
>
> This sentences is in second person, and the previous one was in third
> person.
how about "the list will be passed to stack at flush time..." ?

>
> > +the number of skbs in this list exceeds gro_normal_batch.
>
> s/skbs/segments/
right.

Thanks.

>
> > +Default : 8
> > +
> >  2. /proc/sys/net/unix - Parameters for Unix domain sockets
> >  ----------------------------------------------------------
> >
>