netdev - Re: [PATCH net] Documentation: add description for net.core.gro_normal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220509180712.22f4a3a7@kernel.org>
Date:   Mon, 9 May 2022 18:07:12 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, davem@...emloft.net,
        Edward Cree <ecree@...arflare.com>
Subject: Re: [PATCH net] Documentation: add description for
 net.core.gro_normal_batch

On Fri,  6 May 2022 14:20:13 -0400 Xin Long wrote:
> Describe it in admin-guide/sysctl/net.rst like other Network core options.
> Users need to know gro_normal_batch for performance tuning.
> 
> Fixes: 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs")
> Reported-by: Prijesh <prpatel@...hat.com>

Does Prijesh have a last name? :)

> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---
>  Documentation/admin-guide/sysctl/net.rst | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/admin-guide/sysctl/net.rst b/Documentation/admin-guide/sysctl/net.rst
> index f86b5e1623c6..d8a8506f31ad 100644
> --- a/Documentation/admin-guide/sysctl/net.rst
> +++ b/Documentation/admin-guide/sysctl/net.rst
> @@ -374,6 +374,16 @@ option is set to SOCK_TXREHASH_DEFAULT (i. e. not overridden by setsockopt).
>  If set to 1 (default), hash rethink is performed on listening socket.
>  If set to 0, hash rethink is not performed.
>  
> +gro_normal_batch
> +----------------
> +
> +Maximum number of GRO_NORMAL skbs to batch up for list-RX. When GRO decides
> +not to coalesce a packet, instead of passing it to the stack immediately,
> +place it on a list. 

That makes it sounds like only packets which were not coalesced 
go on the list. IIUC everything goes on that list before traveling 
up the stack, no?

> +Pass this list to the stack at flush time or whenever

This sentences is in second person, and the previous one was in third
person.

> +the number of skbs in this list exceeds gro_normal_batch.

s/skbs/segments/

> +Default : 8
> +
>  2. /proc/sys/net/unix - Parameters for Unix domain sockets
>  ----------------------------------------------------------
>