netdev - Re: [PATCH net] Documentation: add description for net.core.gro_normal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11f25fef-e551-f72c-223d-c3d072a3a94d@xilinx.com>
Date:   Tue, 10 May 2022 18:42:22 +0100
From:   Edward Cree <edward.cree@...inx.com>
To:     Xin Long <lucien.xin@...il.com>, Jakub Kicinski <kuba@...nel.org>
CC:     network dev <netdev@...r.kernel.org>, davem <davem@...emloft.net>,
        "Edward Cree" <ecree@...arflare.com>
Subject: Re: [PATCH net] Documentation: add description for
 net.core.gro_normal_batch

On 10/05/2022 18:10, Xin Long wrote:
> On Mon, May 9, 2022 at 9:07 PM Jakub Kicinski <kuba@...nel.org> wrote:
>> That makes it sounds like only packets which were not coalesced
>> go on the list. IIUC everything goes on that list before traveling
>> up the stack, no?
> I think the difference is these ones held/merged go to gro_list first
> and get merged there, then go to the list. I can change it to:
> 
> "place it on a list where the coalesced packets also eventually go"
> 
> looks good?

Maybe it'd be clearer to say something like
"when a packet exits GRO, either as a coalesced superframe or as an
 original packet which GRO has decided not to coalesce, it is placed on
 a per-NAPI list.  This list is then passed to the stack when..." etc.
Ideally also mention the fact that a coalesced superframe counts as
 napi_gro_cb.count towards the gro_normal_batch limit, not just 1.

-ed