netdev - Re: [PATCH net] Documentation: add description for net.core.gro_normal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvbK_f1B-HjSu1w7VX2=8KPkw+ecLf1aOfgcmcp48MGQNQEig@mail.gmail.com>
Date:   Wed, 11 May 2022 12:20:16 -0400
From:   Xin Long <lucien.xin@...il.com>
To:     Edward Cree <edward.cree@...inx.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        network dev <netdev@...r.kernel.org>,
        davem <davem@...emloft.net>, Edward Cree <ecree@...arflare.com>
Subject: Re: [PATCH net] Documentation: add description for net.core.gro_normal_batch

On Tue, May 10, 2022 at 1:42 PM Edward Cree <edward.cree@...inx.com> wrote:
>
> On 10/05/2022 18:10, Xin Long wrote:
> > On Mon, May 9, 2022 at 9:07 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >> That makes it sounds like only packets which were not coalesced
> >> go on the list. IIUC everything goes on that list before traveling
> >> up the stack, no?
> > I think the difference is these ones held/merged go to gro_list first
> > and get merged there, then go to the list. I can change it to:
> >
> > "place it on a list where the coalesced packets also eventually go"
> >
> > looks good?
>
> Maybe it'd be clearer to say something like
> "when a packet exits GRO, either as a coalesced superframe or as an
>  original packet which GRO has decided not to coalesce, it is placed on
>  a per-NAPI list.  This list is then passed to the stack when..." etc.
> Ideally also mention the fact that a coalesced superframe counts as
>  napi_gro_cb.count towards the gro_normal_batch limit, not just 1.
Thanks, ed.

I'd say "...when the segments in this list count towards the
gro_normal_batch limit." only
(too many details involved may confuse users)

will post v2.