netdev - RE: [PATCH net-next 1/2] net: enetc: manage ENETC_F_QBV in priv->active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM9PR04MB8397DBDAA510B947A4132D7D96C89@AM9PR04MB8397.eurprd04.prod.outlook.com>
Date:   Wed, 11 May 2022 08:17:45 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Vladimir Oltean <vladimir.oltean@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        Michael Walle <michael@...le.cc>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>
Subject: RE: [PATCH net-next 1/2] net: enetc: manage ENETC_F_QBV in
 priv->active_offloads only when enabled

> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@....com>
> Sent: Tuesday, May 10, 2022 7:36 PM
[...]
> Subject: [PATCH net-next 1/2] net: enetc: manage ENETC_F_QBV in priv-
> >active_offloads only when enabled
> 
> Future work in this driver would like to look at priv->active_offloads &
> ENETC_F_QBV to determine whether a tc-taprio qdisc offload was
> installed, but this does not produce the intended effect.
> 
> All the other flags in priv->active_offloads are managed dynamically,
> except ENETC_F_QBV which is set statically based on the probed SI capability.
> 
> This change makes priv->active_offloads & ENETC_F_QBV really track the
> presence of a tc-taprio schedule on the port.
> 
> Some existing users, like the enetc_sched_speed_set() call from
> phylink_mac_link_up(), are best kept using the old logic: the tc-taprio
> offload does not re-trigger another link mode resolve, so the scheduler
> needs to be functional from the get go, as long as Qbv is supported at
> all on the port. So to preserve functionality there, look at the static
> station interface capability from pf->si->hw_features instead.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Claudiu Manoil <claudiu.manoil@....com>