netdev - Re: [PATCH net-next 14/14] net: txgbe: Support sysfs file system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ynzy0ZOJh68nI3dx@lunn.ch>
Date:   Thu, 12 May 2022 13:43:13 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jiawen Wu <jiawenwu@...stnetic.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 14/14] net: txgbe: Support sysfs file system

On Wed, May 11, 2022 at 11:26:59AM +0800, Jiawen Wu wrote:
> Add support for sysfs file system.

Please always Cc: the hwmon maintainers for hwmon patches.

> +	txgbe_hwmon->device =
> +			hwmon_device_register(pci_dev_to_dev(adapter->pdev));

I _think_ the preferred interface is
hwmon_device_register_with_groups() or
hwmon_device_register_with_info(). The hwmon maintainer will tell you.

	Andrew