lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 12 May 2022 14:12:49 +0200
From:   Lukas Wunner <>
Cc:     Andrew Lunn <>
Subject: Re: [PATCH net-next v3 3/7] usbnet: smsc95xx: Don't reset PHY behind
 PHY driver's back

On Thu, May 12, 2022 at 10:42:03AM +0200, Lukas Wunner wrote:
> smsc95xx_reset() resets the PHY behind the PHY driver's back, which
> seems like a bad idea generally.  Remove that portion of the function.
> We're about to use PHY interrupts instead of polling to detect link
> changes on SMSC LAN95xx chips.  Because smsc95xx_reset() is called from
> usbnet_open(), PHY interrupt settings are lost whenever the net_device
> is brought up.
> There are two other callers of smsc95xx_reset(), namely smsc95xx_bind()
> and smsc95xx_reset_resume(), and both may indeed benefit from a PHY
> reset.  However they already perform one through their calls to
> phy_connect_direct() and phy_init_hw().
> Tested-by: Oleksij Rempel <> # LAN9514/9512/9500
> Tested-by: Ferry Toth <> # LAN9514
> Signed-off-by: Lukas Wunner <>
> Cc: Martyn Welch <>
> Cc: Gabriel Hojda <>

Reviewed-by: Andrew Lunn <>

Andrew kindly provided this tag here:

Forgot to add it to the commit.
Sending it in separately so patchwork picks it up.
My apologies for the inconvenience.

Powered by blists - more mailing lists