netdev - Re: [PATCH net-next 10/14] net: txgbe: Add ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ynz5jZUQorkPmJ/o@lunn.ch>
Date:   Thu, 12 May 2022 14:11:57 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jiawen Wu <jiawenwu@...stnetic.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 10/14] net: txgbe: Add ethtool support

> +int txgbe_get_link_ksettings(struct net_device *netdev,
> +			     struct ethtool_link_ksettings *cmd)
> +{
> +	struct txgbe_adapter *adapter = netdev_priv(netdev);
> +	struct txgbe_hw *hw = &adapter->hw;
> +	u32 supported_link;
> +	u32 link_speed = 0;
> +	bool autoneg = false;
> +	u32 supported, advertising;
> +	bool link_up;



> +
> +	if (!in_interrupt()) {
> +		TCALL(hw, mac.ops.check_link, &link_speed, &link_up, false);
> +	} else {
> +		/* this case is a special workaround for RHEL5 bonding
> +		 * that calls this routine from interrupt context
> +		 */
> +		link_speed = adapter->link_speed;
> +		link_up = adapter->link_up;
> +	}

Does mainline do this? You are contributing this driver to mainline,
not a vendor kernel. Don't work around vendor issues.

    Andrew