netdev - Re: [PATCH net-next 04/14] net: txgbe: Add PHY interface support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ynz7x85dmUrk1smo@lunn.ch>
Date:   Thu, 12 May 2022 14:21:27 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jiawen Wu <jiawenwu@...stnetic.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 04/14] net: txgbe: Add PHY interface support

> -s32 txgbe_reset_hw(struct txgbe_hw *hw)
> +s32 txgbe_set_link_to_kr(struct txgbe_hw *hw, bool autoneg)
>  {


> +	if (1) {
> +		/* 2. Disable xpcs AN-73 */

You don't use if (1) in kernel quality code.

    Andrew