netdev - Re: [PATCH net-next 0/4] net: skb: check the boundrary of skb drop reason

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 May 2022 20:31:14 +0800
From:   Menglong Dong <menglong8.dong@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Neil Horman <nhorman@...driver.com>,
        David Miller <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Menglong Dong <imagedong@...cent.com>,
        Martin Lau <kafai@...com>, Talal Ahmad <talalahmad@...gle.com>,
        Kees Cook <keescook@...omium.org>, asml.silence@...il.com,
        Willem de Bruijn <willemb@...gle.com>,
        vasily.averin@...ux.dev,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/4] net: skb: check the boundrary of skb drop reason

On Thu, May 12, 2022 at 2:26 PM <menglong8.dong@...il.com> wrote:
>
> From: Menglong Dong <imagedong@...cent.com>
>
> In the commit 1330b6ef3313 ("skb: make drop reason booleanable"),
> SKB_NOT_DROPPED_YET is added to the enum skb_drop_reason, which makes
> the invalid drop reason SKB_NOT_DROPPED_YET can leak to the kfree_skb
> tracepoint. Once this happen (it happened, as 4th patch says), it can
> cause NULL pointer in drop monitor and result in kernel panic.
>
> Therefore, check the boundrary of drop reason in both kfree_skb_reason
> (2th patch) and drop monitor (1th patch).
>
> Meanwhile, fix the invalid drop reason passed to kfree_skb_reason() in
> tcp_v4_rcv().
>

tcp_v6_rcv() is forgeted, I'll send a V2 :/

> Menglong Dong (4):
>   net: dm: check the boundary of skb drop reasons
>   net: skb: check the boundrary of drop reason in kfree_skb_reason()
>   net: skb: change the definition SKB_DR_SET()
>   net: tcp: reset skb drop reason to NOT_SPCIFIED in tcp_v4_rcv()
>
>  include/linux/skbuff.h  | 3 ++-
>  net/core/drop_monitor.c | 2 +-
>  net/core/skbuff.c       | 5 +++++
>  net/ipv4/tcp_ipv4.c     | 1 +
>  4 files changed, 9 insertions(+), 2 deletions(-)
>
> --
> 2.36.1
>