netdev - Re: [PATCH net-next v3 7/7] net: phy: smsc: Cope with hot-removal in interrupt handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220512121915.GE4703@wunner.de>
Date:   Thu, 12 May 2022 14:19:15 +0200
From:   Lukas Wunner <lukas@...ner.de>
To:     netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next v3 7/7] net: phy: smsc: Cope with hot-removal in
 interrupt handler

On Thu, May 12, 2022 at 10:42:07AM +0200, Lukas Wunner wrote:
> If reading the Interrupt Source Flag register fails with -ENODEV, then
> the PHY has been hot-removed and the correct response is to bail out
> instead of throwing a WARN splat and attempting to suspend the PHY.
> The PHY should be stopped in due course anyway as the kernel
> asynchronously tears down the device.
> 
> Tested-by: Oleksij Rempel <o.rempel@...gutronix.de> # LAN9514/9512/9500
> Tested-by: Ferry Toth <fntoth@...il.com> # LAN9514
> Signed-off-by: Lukas Wunner <lukas@...ner.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

Andrew kindly provided this tag here:
https://lore.kernel.org/netdev/YnGsKQC1WxihasYs@lunn.ch/

Forgot to add it to the commit.
Sending it in separately so patchwork picks it up.
My apologies for the inconvenience.